Fix Qiskit circuit conversion to Tenet #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jofrevalles
approved these changes
Jan 20, 2025
mofeing
reviewed
Jan 23, 2025
| @@ -11,7 +11,7 @@ function Base.convert(::Type{Circuit}, ::Val{:qiskit}, pyobj::Py) | |||
| circuit = Circuit() | |||
|
|
|||
| for instr in pyobj | |||
| gatelanes = map(x -> Lane(pyconvert(Int, x._index)), instr.qubits) | |||
| gatelanes = map(x -> Lane(pyconvert(Int, x._index) + 1), instr.qubits) | |||
There was a problem hiding this comment.
I just have one question: are we sure that Qiskit only uses 1-dimensional coordinates for qubits? Do you mind checking it in the docs?
There was a problem hiding this comment.
If your question is whether the qubits field is always a 1D array, then yes, I think so.
There was a problem hiding this comment.
This says a list, so yes.
https://docs.quantum.ibm.com/api/qiskit/qiskit.circuit.QuantumCircuit#qubits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves two bugs:
Circuitinstead ofQuantumwhen converting a Qiskit circuit to Tenet (resolved in Fix Python environment and integration tests for Python extensions #300)1instead of0